Forms Update #8112
Merged
Forms Update #8112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacker
approved these changes
Oct 26, 2016
docs/docs/forms.md
Outdated
| ``` | ||
|
|
||
| If you wanted to listen to updates to the value, you could use the `onChange` event just like you can with controlled components. | ||
| If you wanted to listen to updates to the value, you could use the `onChange` event just like you can with controlled components, however you would _not_ pass the value you saved to the component. |
There was a problem hiding this comment.
Just a phrasing nitpick - can you break this up into two sentences like:
If you wanted to listen to updates to the value, you could use the
onChangeevent just like you can with controlled components. However, you would not pass the value you saved to the component.
docs/docs/forms.md
Outdated
| } | ||
| let value = event.target.value; | ||
| let checked = this.state.checked; // copy | ||
| if(!checked[value]) { checked[value] = true; } else { checked[value] = false; } |
There was a problem hiding this comment.
can you put a space after if and break this up into multiple lines so it matches the style of other parts?
docs/docs/forms.md
Outdated
| handleSubmit(event) { | ||
| alert("Boxes checked are: '" + this.state.checked + "'"); | ||
| alert("Boxes checked: " + | ||
| (this.state.checked.A?"A ":"") + |
There was a problem hiding this comment.
can you put spaces around the ? and : operators when you're ternarying
lacker
reviewed
Oct 26, 2016
docs/docs/forms.md
Outdated
| handleSubmit(event) { | ||
| alert("Boxes checked are: '" + this.state.checked + "'"); | ||
| alert("Boxes checked: " + | ||
| (this.state.checked.A ? "A ":"") + |
There was a problem hiding this comment.
spaces around the : too, plz
This was referenced Oct 26, 2016
Closed
|
Thank you! |
gaearon
added
Component: Documentation & Website
and removed
Documentation: needs merge to stable
labels
gaearon
pushed a commit
that referenced
this pull request
Oct 27, 2016
* Reapplied fixes to updated docs from master * Reapplied fixes to Forms, removed ES2016 function includes() * Missing carriage return * Adding back some line breaks * Making requested changes. * Making space changes
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
* Reapplied fixes to updated docs from master * Reapplied fixes to Forms, removed ES2016 function includes() * Missing carriage return * Adding back some line breaks * Making requested changes. * Making space changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 8052
Fixes 8068